[vlc-devel] [PATCH] lua: build luac for the build, not the host

[Rafaël Carré]

Le 2012-02-10 02:47, Rémi Denis-Courmont a écrit :
> On Thu, 09 Feb 2012 18:44:33 -0500, Rafaël Carré <funman at videolan.org>
> wrote:
>>> And I think contrib is not meant to, has no support for, and should
>>> not target the build platform in any way.
>>
>> That's not correct,
> 
> Yes it is. I designed the current contrib system. I think I know that
> design limitation. It might or might not be possible to extend it to
> support build-tools in a clean fashion. But it has not been done (and this
> patch does not fix that).
> 
>> contribs build:
>> * autopoint/gettextize shell scripts to be run on the build platform
> 
> Not true.

I am pretty much sure autopoint is needed on OSX.

>> * moc/uic/rcc executables for both target and build platform
> 
> Not by me and it most probably has bugs there.

That's a rather unfounded claim

> 
>> * luac
> 
> Only for host -not build- and not actually used.

Yeah I'd rather like to use it to ensure we ship .luac in the desired
format.

>> This lua patch you wrote ensures we only load a specific .luac format.
>> Then we need a luac executable that compiles to that specific format.
> 
> And we also need autoconf, automake, awk, binutils, bzip2, gcc, gzip, g++,
> libtool, make, perl, pkg-config, python, sed, tar, xcb-proto, xz and a
> shell. So what?

win64 NB is broken, and win32 NB is not broken because it runs in a
32-bits environment.

Here are the solutions I see:
- apply this patch, it works most of the time on scenarios I care about
(targetting windows/osx/android). You haven't brought any real problem
about it except "It doesn't fit in the scheme that I designed"
- check for a 32bits luac in configure.ac (how?)
- revert 01ec2d6e8c9347a0, check for a 64 bits luac in configure.ac when
targetting 64 bits, 32 when targetting 32.
- stop using .luac completely or only when cross compiling


What was the point of 01ec2d6e8c9347a0 anyway ?

It certainly does not "ease cross-compilation" as announced.