[vlc-devel] [PATCH] arm_neon: YUV->RGBA Only allow pitch to be a multiple of 16 on output

[XilasZ]

> I still think it should check the pitch and not the width.

yes

> Also since height is incremented by 2 in the asm I think it should also
> check for height % 2.

is it even possible to have i420 frames which are not mutliples of 2 ?

2012/2/10 Rémi Denis-Courmont <remi at remlab.net>

> On Fri, 10 Feb 2012 12:22:38 +0000, Asad Mehmood
> <asad78611 at googlemail.com>
> wrote:
> >> The same issue still exists, if you have a width of 520 for instance,
> >> it's a
> >> multiple of 4, but not a multiple of 16.
> >> It will crash on your device.
> >
> > I might have misunderstood this ...
> >
> > But I though that if the width was a multiple of 4 for the output the
> > pitch would be a multiple of 16 in RGBA space.
> >
> > e.g. A width of 520 will have a pitch of 2080?
>
> You seem to assume that
>
>  pitch == pixel_width * bytes_per_pixel
>
> while actually:
>
>  pitch >= pixel_width * bytes_per_pixel
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120210/10233095/attachment.html>