[vlc-devel] [PATCH] Use newer theora API and fix windows crash (Close #3841)

Jean-Baptiste Kempf jb at videolan.org
Sat Feb 11 02:10:09 CET 2012

On Fri, Feb 10, 2012 at 05:00:17PM -0800, Theron Lewis wrote :
> On Fri, Feb 10, 2012 at 4:17 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> > I was mostly thinking about that one:
> > http://v2v.cc/~j/theora_testsuite/offset_test.ogv
> It passes all of the tests except for that one.  VLC won't play it but
> it doesn't crash either.

It does not work with VLC IIRC, but, the important is the line
requesting the vout. If it does say 512, this is fine.

> I've attached a 2nd patch with the requested cleanups that also
> handles the malloc failure.

Please squash those 2 patches (git rebase -i origin/naster is awesome if
you don't know about it).

> I'll take a look at the offset issue but
> it's probably beyond the scope of this patch and I won't be able to
> get to it until next week so I'll submit that as a new patch for that.


> Also could you consider patching the 2.0.0 branch as well as master
> branch with this fix?  Thanks!

Once merged, we will see, but yes, probably, seeing the number of
duplicate of #3841.

Best regards,

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list