[vlc-devel] [vlc-commits] Remove select timeout.

Pierre Ynard linkfanel at yahoo.fr
Sat Feb 11 19:27:56 CET 2012

> vlc | branch: master | Antoine Cellerier <dionoea at videolan.org> | Sat
> Feb 11 11:57:11 2012 +0100| [ea6dc345a8cad5a1ff26dab8385776e68793b429] |
> committer: Antoine Cellerier
> Remove select timeout.
> console and socket mode are now exclusive on windows.

Okay, that could make sense, if done correctly.

>                     if client.status == status.read or client.status == status.password then
>                         if vlc.win.console_wait(50) then
>                             table.insert(rclients, client)
>                         end
>                     else
>                         table.insert(wclients, client)
>                     end

You still export in the API, and use, Windows-specific code, that
moreover uses shitty timeouts and busy loops. Even if you fixed the most
blatant mistakes, this API and "design" for lua interfaces is still

Besides, you didn't address my other comments or even questions on the
C code. Nor were you willing to engage in design discussion besides
"better something questionable but that works" and "I chose this design
because it was fun to code". This is "unfriendly".

I'd still NAK this patch.

Pierre Ynard
"Une âme dans un corps, c'est comme un dessin sur une feuille de papier."

More information about the vlc-devel mailing list