[vlc-devel] [PATCH 10/13] dash: added buffer size to prefs

[Christopher Müller]

> Von: Hugo Beauzée-Luyssen [mailto:beauze.h at gmail.com]
> Gesendet: Dienstag, 14. Februar 2012 16:24
> An: Mailing list for VLC media player developers
> Cc: Christopher Mueller
> Betreff: Re: [vlc-devel] [PATCH 10/13] dash: added buffer size to prefs
> 
> Hello again,
> 
> On Sat, Feb 11, 2012 at 12:00 PM,  <Christopher at mailsrv.uni-klu.ac.at>
> wrote:
> > From: Christopher Mueller <christopher.mueller at itec.aau.at>
> >
> > ---
> >  modules/stream_filter/dash/dash.cpp |   11 ++++++++---
> >  1 files changed, 8 insertions(+), 3 deletions(-)
> >
> > diff --git a/modules/stream_filter/dash/dash.cpp
> > b/modules/stream_filter/dash/dash.cpp
> > index 3b1ac7a..1b02b65 100644
> > --- a/modules/stream_filter/dash/dash.cpp
> > +++ b/modules/stream_filter/dash/dash.cpp
> > @@ -54,6 +54,9 @@ static void Close   (vlc_object_t *);
> >  #define DASH_HEIGHT_TEXT N_("Preferred Height")
> >  #define DASH_HEIGHT_LONGTEXT N_("Preferred Height")
> >
> > +#define DASH_BUFFER_TEXT N_("Buffer Size (Seconds)") #define
> > +DASH_BUFFER_LONGTEXT N_("Buffer size in seconds")
> > +
> >  vlc_module_begin ()
> >         set_shortname( N_("DASH"))
> >         set_description( N_("Dynamic Adaptive Streaming over HTTP") )
> > @@ -62,6 +65,7 @@ vlc_module_begin ()
> >         set_subcategory( SUBCAT_INPUT_STREAM_FILTER )
> >         add_integer( "dash-prefwidth",  480, DASH_WIDTH_TEXT,
> > DASH_WIDTH_LONGTEXT,  true )
> >         add_integer( "dash-prefheight", 360, DASH_HEIGHT_TEXT,
> > DASH_HEIGHT_LONGTEXT, true )
> > +        add_integer( "dash-bufferSize", 30, DASH_BUFFER_TEXT,
> > + DASH_BUFFER_LONGTEXT, true )
> 
> It should be dash-buffersize to be consistant with the other options
> naming scheme.
> Otherwise, good to me, but the option isn't used yet, is this part of
> some local changes on your side or just an omission?

I agree with the consistency issue this is my fault ;). The option is used in the constructor of BlockBuffer.cpp.

> 
> >         set_callbacks( Open, Close )
> >  vlc_module_end ()
> >
> > @@ -116,9 +120,10 @@ static int Open(vlc_object_t *p_obj)
> >             new dash::DASHManager( p_conManager, p_sys->p_mpd,
> >
> > dash::logic::IAdaptationLogic::RateBased, p_stream);
> >
> > -    if ( p_dashManager->getMpdManager() == NULL ||
> > -         p_dashManager->getMpdManager()->getMPD() == NULL ||
> > -         p_dashManager->getAdaptionLogic() == NULL )
> > +    if ( p_dashManager->getMpdManager()           == NULL   ||
> > +         p_dashManager->getMpdManager()->getMPD() == NULL   ||
> > +         p_dashManager->getAdaptionLogic()        == NULL   ||
> > +         p_dashManager->start()                   == false)
> >     {
> >         delete p_conManager;
> >         delete p_dashManager;
> > --
> > 1.7.0.4
> >
> 
> Best regards,
> 
> --
> Hugo Beauzée-Luyssen