[vlc-devel] [vlc-commits] OSX GUI: don't check for interface pointer

Rafaël Carré funman at videolan.org
Wed Feb 15 21:03:32 CET 2012


Le 12-02-15 14:51, Felix Paul Kühne a écrit :
> 
> On 15.02.2012, at 20:49, Rafaël Carré wrote:
> 
>> OSX GUI: don't check for interface pointer
>>
>> It'll be valid the first time this function is called
> 
> So, you already gave the reason why this commit is wrong.
> 
> applicationWillTerminate can be executed N times, but will crash on the 2nd.
> 
> There are currently at least 2 objects pushing the respective notification and the cocoa runtime is allowed to do so as well.

The code touched by previous commit (which was already present) already
takes care that a second (or any subsequent) call has no effect.



More information about the vlc-devel mailing list