[vlc-devel] [PATCH 1/4] Treat UTF-16 as UCS-2 on OS/2

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> On Thu, 16 Feb 2012 15:38:04 -0500, Rafaël Carré <funman at videolan.org>
> wrote:
>> Since the code is #ifdef'd for OS2 I think there should be no problem to
>> apply.
> 
> This will introduce error cases, or perhaps unexpected resutls in some
> cases. For instance, converting valid UTF-8 to UTF-16 or valid UTF-16 to
> UTF-8 cannot normally fail.
> 

Normally. But UTF-16 is not supported by OS/2 at all.

And UCS-2 supports the most parts of UTF-16.

Anyway, it's better than nothing.

> I do not know if this is a problem, the affected VLC code base is too big
> for me to (care to) review.
> 

Of course, I'll try to fix if a problem is found.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66GHz with 2GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr