[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

[Jean-Baptiste Kempf]

On Fri, Feb 17, 2012 at 02:40:38PM -0600, Ron Wright wrote :
> +#define WINAMP_BANDS_TEXT N_( "Use Winamp frequency bands" )
> +#define WINAMP_BANDS_LONGTEXT N_( \
> +         "Use the frequency bands used in Winamp. Otherwise, use the ISO " \
> +         "Standard frequency bands." )

> +    add_bool( "equalizer-winampfreqs", true, NULL, WINAMP_BANDS_TEXT,
> +              WINAMP_BANDS_LONGTEXT, true )

No. Winamp is a registered trademark.

> +    double d_rate = (double) i_rate;
> +    double d_nyquist_freq = 0.5 * d_rate;
> +    double d_octave_factor = pow( 2.0, 0.5 * d_octave_percent );

Do you need double here?

> +    int i;

Declare it in the for loop. We are C99.

> +    EqzCoeffs( i_rate, 1.0,
> +               var_CreateGetBool( p_aout, "equalizer-winampfreqs" ), &cfg );

Sure you do not need inherit here?

> +    int i;
as above.

> diff -purN a/modules/gui/qt4/ui/equalizer.ui b/modules/gui/qt4/ui/equalizer.ui
> --- a/modules/gui/qt4/ui/equalizer.ui	2010-04-12 19:22:27.000000000 -0500
> +++ b/modules/gui/qt4/ui/equalizer.ui	2011-07-06 18:20:46.371654207 -0500
> @@ -36,6 +36,13 @@
>        </widget>
>       </item>
>       <item>
> +      <widget class="QCheckBox" name="winampFreqCheck" >
> +       <property name="text" >
> +        <string>Use Winamp Frequency Bands</string>
> +       </property>
> +      </widget>
> +     </item>
> +     <item>
>        <spacer>

I do not see why we need to be able to change those freq live. This is
not something you change all the time.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device