[vlc-devel] [PATCH]Equalizer, support other sampling rates than 44100 and 48000

[Ron Wright]

All right, it seems that all issues have been resolved (except for one).
There is no mention of Winamp anywhere, doubles have been changed to
floats, the method of creating the "equalizer-classicvlcfreqs" parameter is
explicitly set to inherit, the return value VLC_SUCCESS has been added to
the classic VLC frequency callback function, and C99-style declarations are
used in the "for" loops.  However, I have two possibilities here:  should
the "Use Classic VLC Frequency Bands" checkbox be placed beside the
"Enable" and "2 Pass" checkbox at the cost of a wider window (version 1
patch), or should it be placed below the frequency adjustment sliders at
the cost of a taller window (version 2 patch)?

On Mon, Feb 20, 2012 at 1:50 AM, Jean-Baptiste Kempf <jb at videolan.org>wrote:

> On Sun, Feb 19, 2012 at 10:55:10PM -0600, Ron Wright wrote :
> > All right, so I guess introducing another frequency band isn't such a
> great
> > idea after all if it requires using a registered trademark to describe
> the
>
> Just call it "Classic VLC bands" :)
> I think it is a good idea to provide both, just not to call it Winamp.
>
> Best regards,
>
> --
> Jean-Baptiste Kempf
> http://www.jbkempf.com/ - +33 672 704 734
> Sent from my Electronic Device
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120220/b8a73a9c/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Improve-equalizer.patch
Type: text/x-patch
Size: 16391 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120220/b8a73a9c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Improve-equalizer-version-2.patch
Type: text/x-patch
Size: 16895 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120220/b8a73a9c/attachment-0001.bin>