[vlc-devel] [PATCH] DASH: prevent integer overflow

Frederic YHUEL fyhuel at viotech.net
Thu Feb 23 18:06:12 CET 2012

On Thu, Feb 23, 2012 at 4:19 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> On Thu, Feb 23, 2012 at 11:59:55AM +0100, fyhuel at viotech.net wrote :
>> A integer overflow could happen in bandwidth computation, for example if
>> we have a DASH server and client on the same machine.
> Could you explain that use case?

Well, I was playing with DASH, with a server and client on the same
machine when I noticed that integer overflow.

If I did the math right, we get an integer overflow if we have a
bandwidth greater than 269 MB/s. Who doesn't ?!

Seriously, I thought it might happen in the following use case: the
DASH server is in a set-top box and the DASH client is a PC connected
with gigabyte Ethernet.

But actually, no, even in that case we should be safe.

Sorry for the noise.


More information about the vlc-devel mailing list