[vlc-devel] [PATCH 2/3] Audioscrobbler: Update the scrobbling protocol to the version 2.0.

[Ilkka Ollakka]

On Fri, Feb 24, 2012 at 11:08:19PM +0100, Samuel Pitoiset wrote:

Hi,

Thanks for the patch, one thing that I spotted that is problematic

> --- a/modules/misc/audioscrobbler.c
> +++ b/modules/misc/audioscrobbler.c
> @@ -1209,6 +1209,274 @@ static void HandleInterval(mtime_t *next, unsigned int *i_interval)
> +
> +    vlc_mutex_lock(&p_sys->lock);
> +    for (i_song = 0 ; i_song < p_sys->i_songs ; i_song++)
> +    {
> +        audioscrobbler_song_t *p_song = &p_sys->p_queue[i_song];
> +        char psz_key[1204], psz_val[1024];
> +
> +        /* album */
> +        sprintf(psz_key, "album[%d]", i_song);
> +        sprintf(psz_val, "%s", p_song->psz_b);

I think it would be better to use snprintf here, and is that psz_key
really 1204 and not 1024? So change all sprintf stuff to snprintf
or something safer. This is issue if there is song that has metadata
for example 2000 characters long and you only have 1024 character of
memory where you write it. Atleast I did not spot any checks for
p_song->psz_b length limitting in current core.

-- 
Ilkka Ollakka
You will be surprised by a loud noise.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120225/54f7fab0/attachment.sig>