[vlc-devel] [PATCH 1/3] Audioscrobbler: Update the handshake protocol to the version 2.0.

[Ilkka Ollakka]

On Fri, Feb 24, 2012 at 11:08:18PM +0100, Samuel Pitoiset wrote:
> ---
>      audioscrobbler_song_t   p_queue[QUEUE_MAX]; /**< songs not submitted yet*/
> @@ -114,6 +129,10 @@ static void Run             (intf_thread_t *);
>  #define USERNAME_LONGTEXT   N_("The username of your last.fm account")
>  #define PASSWORD_TEXT       N_("Password")
>  #define PASSWORD_LONGTEXT   N_("The password of your last.fm account")
> +#define API_KEY_TEXT        N_("API key")
> +#define API_KEY_LONGTEXT    N_("The API key of your last.fm account")
> +#define API_SECRET_TEXT     N_("API secret")
> +#define API_SECRET_LONGTEXT N_("The API secret key of your last.fm account")

> @@ -133,7 +152,11 @@ vlc_module_begin ()
>                  USERNAME_TEXT, USERNAME_LONGTEXT, false)
>      add_password("lastfm-password", "",
>                  PASSWORD_TEXT, PASSWORD_LONGTEXT, false)
> -    add_string("scrobbler-url", "post.audioscrobbler.com",
> +    add_string("lastfm-api-key", "",
> +                API_KEY_TEXT, API_KEY_LONGTEXT, false)
> +    add_string("lastfm-api-secret", "",
> +                API_SECRET_TEXT, API_SECRET_LONGTEXT, false)

Does the new api require api-key and api-secret from user? Should those
fields be in simple preferences and should error-dialog have url where
to get them if they are missing?

-- 
Ilkka Ollakka
Brain, v. [as in "to brain"]:
	To rebuke bluntly, but not pointedly; to dispel a source of
error in an opponent.
		-- Ambrose Bierce, "The Devil's Dictionary"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120225/6bae9f8c/attachment.sig>