[vlc-devel] [PATCH] Mac OS X: access_screen: support Lion, add Display ID options

[FUJISAWA Tooru]

Thank you for reviewing.

On 2012/02/26, at 18:18, Jean-Baptiste Kempf wrote:
>> and added option to capture secondary display.
> 
> Did you add rectangle selection too?

Yes, subscreen feature works in any (main, secondary or other) display.
Independent coordinates: (0, 0) means top-left corner for each one.
Capturing subscreen which accross two or more display is not implemented.

> You should use calloc instead of malloc+memset.

Okay, I fixed whole patch:
http://homepage.mac.com/arai_a/fixed/0001-Mac-OS-X-access_screen-support-Lion-add-Display-ID-o.patch

>> On the other hand, I have no idea to avoid using CGLSetOffScreen to create offscreen context, still used.
> 
> And it does work on Lion? If so, cool.

Yes, I've tested this patch in Lion and it works well.

Best Regards.

--
arai / FUJISAWA Tooru <arai_a at mac.com>