[vlc-devel] [Patch] Don't compute a psz_file when something is not a file.

Laurent Aimar fenrir at elivagar.org
Mon Feb 27 10:09:53 CET 2012


On Sun, Feb 26, 2012 at 11:29:54PM +0100, Hugo Beauzée-Luyssen wrote:
> Hello,
> 
> While trying to fix HLS for Win32, I came across what I think to be a problem :
> When a demux is created, a psz_file member is computed, based on the
> mrl : "file://<location>", no matter what <location> is.
> This seems wrong when using, for instance, a HTTP based file.
> However, this only changes something on WIN32 (and probably on OS2),
> as everything that doesn't start with a '\' or doesn't contain
> localhost will be prepended with a double backslash.

 The psz_file is there as an helper, I don't see anything wrong it setting it
when it is not needed. Anyway, file:// is not the only URL scheme that
will use the same sementic (directory://, maybe dvd:// and bd://, etc) and
so your patch may break things.

-- 
fenrir



More information about the vlc-devel mailing list