[vlc-devel] [PATCH] DASH: prevent integer overflow
beauze.h at gmail.com
Mon Feb 27 14:04:07 CET 2012
On Mon, Feb 27, 2012 at 2:00 PM, Hugo Beauzée-Luyssen
<beauze.h at gmail.com> wrote:
> On Mon, Feb 27, 2012 at 1:51 PM, Frederic YHUEL <fyhuel at viotech.net> wrote:
>> On Mon, Feb 27, 2012 at 12:39 PM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
>>> On Thu, Feb 23, 2012 at 06:06:12PM +0100, Frederic YHUEL wrote :
>>>> But actually, no, even in that case we should be safe.
>>> 10Gbps links exist.
>> Ok, the patch should probably be applied then :-)
>> Best Regards,
> Patch doesn't apply anymore :(
A few remarks though :
- I'd rather use a uint64_t rather than a unsigned long long, but I
don't think it matters anymore.
- It seems the indentation is wrong
- Wouldn't it be simpler just to store the bpsAvg in a uint64 ? I
haven't check the side effects though.
More information about the vlc-devel