[vlc-devel] [PATCH] Mac OS X: access_screen: support Lion, add Display ID options

Jean-Baptiste Kempf jb at videolan.org
Mon Feb 27 15:28:59 CET 2012


On Mon, Feb 27, 2012 at 10:22:28PM +0900, FUJISAWA Tooru wrote :
> Please download fixed patch from here: (fixed indentation and framework loading)
> http://homepage.mac.com/arai_a/fixed2/0001-Mac-OS-X-access_screen-support-Lion-add-Display-ID-o.patch

The code seems fine now.

 - when CGGetOnlineDisplayList fails, I hope Apple files dspyCnt to 0,
   but this isn't said on the documentation.
 - to speed up the code, do not calloc images/regions that will be filled
   anyway; malloc should be faster. Reducing the malloc calls helps, of
   course ;)

Felix: xib review?

Best regards,

PS: why are .xib rewritten every time?

Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device

More information about the vlc-devel mailing list