[vlc-devel] [PATCH] Mac OS X: access_screen: support Lion, add Display ID options

[FUJISAWA Tooru]

Thank you all.

On 2012/02/27, at 23:28, Jean-Baptiste Kempf wrote:
> Remarks:
> - when CGGetOnlineDisplayList fails, I hope Apple files dspyCnt to 0,
>   but this isn't said on the documentation.
> - to speed up the code, do not calloc images/regions that will be filled
>   anyway; malloc should be faster. Reducing the malloc calls helps, of
>   course ;)

Okay, I fixed them.

> PS: why are .xib rewritten every time?

Should I create patch from previous one, instead of whole patch?

On 2012/02/27, at 23:39, Felix Paul Kühne wrote:
> 1) why do you add 2 empty nsmenuitem view's to the xib without any connections to a menu or another super view?

It's just my mistake, I deleted.

> 2) I don't think that the stepper next to the Display ID is a proper idea. Since the display ID tends to be a pseudo-random integer with more than 10 digits, chances are really low that a user selects a correct value by using the stepper.

I used "Display ID" as index for screens (0, 1, 2, ...), not actual CGDirectDisplayID,
so I think stepper is enough for it, but, as you said, it seems that it's confusable name.
I changed it to "Screen Index", and make "Display ID" actual CGDirectDisplayID
(leave them for command-line argument, user no longer have to consider them while using GUI)

> 2.1) I'd implement the Display ID selection the other way around, similar to the simple preferences window. There, we display a list within a popup button with "Screen n (%i * %i)" (width, height), so the user actually see which display s/he wants to select. Internally, you map the selected screen to the gained Display IDs and forward that value to the access module.

It's a nice idea, I changed the field to popup.

Please download patch from here:
http://homepage.mac.com/arai_a/fixed3/0001-Mac-OS-X-access_screen-support-Lion-add-screen-selec.patch

Best Regards.

--
arai / FUJISAWA Tooru <arai_a at mac.com>