[vlc-devel] [PATCH 1/2] Bootstrap on Solaris

[Maciej (Matchek) Bliziński]

2012/2/28 Francois Cartegnie <fcvlcdev at free.fr>
>
> Le 28/02/2012 00:40, Brad Smith a écrit :
> >>> POSIX shell?
> >
> > Solaris' /bin/sh shell is not POSIX compliant.
>
> Workarounds for this problem are already in the wiki for long time.
> /usr/xpg4/bin/sh bootstrap

Why not make it just work for everyone? It's enough to avoid this
particular construct. Instead you can either invert the logic and use
'else', do something like this:

 # Check for pkg-config
-if ! "${PKG_CONFIG:-pkg-config}" --version >/dev/null 2>&1; then
+"${PKG_CONFIG:-pkg-config}" --version >/dev/null 2>&1
+if test $? -ne 0; then
        echo 'Error: "pkg-config" is not installed.' >&2

Is it hard to read?

> Configure will try to reuse /bin/sh, and has been patched.
> export CONFIG_SHELL='/usr/xpg4/bin/sh'

That might help, but there is a hardcoded call to 'sh' in bootstrap,
which resolves to /bin/sh and causes genmf to fail. Perhaps genmf
should be patched to honor CONFIG_SHELL?

Maciej