[vlc-devel] [PATCH 2/2] Work around the lack of dirfd()

Brad Smith brad at comstyle.com
Tue Feb 28 12:08:40 CET 2012


On 28/02/12 6:06 AM, Rémi Denis-Courmont wrote:
> On Tue, 28 Feb 2012 05:37:06 -0500, Brad Smith<brad at comstyle.com>  wrote:
>> On Tue, Feb 28, 2012 at 09:37:28AM +0000, Maciej (Matchek) Blizi??ski
>> wrote:
>>> 2012/2/28 Brad Smith<brad at comstyle.com>:
>>>> Solaris does not have posix_memalign(). This will help..
>>>
>>> I was thinking that a better approach would be to test for
>>> posix_memalign and define it when missing. What do you think?
>>
>> VLC already uses macros and the header is already more or less
>> ready to deal with Solaris. It just needs a bit of tweaking.
>> Here is a better diff.. the OS's that use memalign() should
>> not be a hardcoded list and for OS's where both exist posix_memalign()
>> should be preferred..
>
> This patch breaks 'make check', or at least it should.
>
> No thanks.

Then the original patch I provided is fine for Solaris.

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.




More information about the vlc-devel mailing list