[vlc-devel] Lua extension and vlc.misc

[Rémi Denis-Courmont]

Le mardi 28 février 2012 20:13:09 Jean-Baptiste Kempf, vous avez écrit :
> Hello,
> 
> Since 52d4b4bb1c, vlc.misc.* are not available outside of lua
> interfaces, notably for extensions and sds.
> It seems indeed that vlc.misc was over-exposing things, like should_die
> or quit.
> 
> However, some things were useful, like version() or copyright() or
> cachedir().
> 
> Therefore, I suggest to allow back some of those things for other lua
> modules, and keep the other ones only for intf. I will do the work of
> splitting, but I would need feedback.
> 
> Here is the list of things:
> 
> Those seems safe to explose:
> "version"

Bad idea.

> "copyright"
> "license"

Both useless.

> "datadir"
> "userdatadir"
> "homedir"
> "configdir"
> "cachedir"
> "datadir_list"

All mostly useless and bad ideas, c.f. other post.

> "action_id"

Same as for the MacOS UI: this should not be exposed.

> Those, I do not know:
> "mdate"

Useless in an extension. The only reported use was to reimplement msleep() 
with mdate() and mwait(), which was stupid.

> "mwait"

Mostly harmless but mostly only used for shitty polling code
-> bad idea.

> "lock_and_wait"

Will probably crash.

> "timer"

Same as mwait() -> bad idea.

> Those seems wrong to expose outside of intf:
> 
> "should_die"

Will crash.

> "quit"

Not extension business -> bad idea.

> Opinions?

My opinion is that none of these should be exposed outside interfaces.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis