[vlc-devel] [PATCH] Updated mpris to spec 2.2

Mirsal Ennaime mirsal at videolan.org
Wed Feb 29 21:13:42 CET 2012

Hi Kevin,

On Fri, 2012-02-24 at 14:19 -0500, Kevin Anthony wrote:
> Changes suggested in http://mailman.videolan.org/pipermail/vlc-devel/2012-February/086246.html
> [...]

Applied with minor edits (Cosmetics, whitespace and commit log) thanks !
There is still an issue with CanSetFullscreen though:

> static int
> MarshalCanSetFullscreen( intf_thread_t *p_intf, DBusMessageIter *container )
> {
>     const dbus_bool_t b_ret = (p_intf->p_sys->p_playlist) ? TRUE : FALSE;
> [...]

This is wrong, you should rather check for the existence of a vout
thread (and there is no need for a ternary here)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: This is a digitally signed message part
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120229/491fdfb8/attachment.sig>

More information about the vlc-devel mailing list