[vlc-devel] [PATCH 4/4] A simpler way to sort a list of words

Rafaël Carré funman at videolan.org
Wed Feb 29 23:24:21 CET 2012


Le 2012-02-29 04:48, Maciej Blizinski a écrit :
> There is no reason to `echo $var` if $var is a list of words. Also, there's no
> need to iterate and echo, translating spaces into newlines works just as well.
> ---
>  configure.ac |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 0eb47d5..af6a901 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -4116,7 +4116,7 @@ CPPFLAGS="-I\$(top_srcdir)/include -I\$(top_builddir)/include ${CPPFLAGS}"
>  dnl
>  dnl Sort the modules list
>  dnl
> -PLUGINS=$( (for i in `echo $PLUGINS`; do echo $i; done)|sort|xargs )
> +PLUGINS=`echo $PLUGINS | tr ' ' '\n' |sort|xargs`
>  
>  dnl
>  dnl  Configuration is finished

It looks unused since d771dd566984 and should be removed I think, with
the code in vlc.m4



More information about the vlc-devel mailing list