[vlc-devel] [PATCH] Demux/Playlist: If an URI contains whitespaces, it will now be encoded to %20. Fixes #2924.

Thomas Siegbert sith_dev at gmx.eu
Mon Jan 2 22:06:46 CET 2012


Am 02.01.2012 21:46, schrieb Rémi Denis-Courmont:
> Le lundi 2 janvier 2012 22:40:18 Thomas Siegbert, vous avez écrit :
>> Am 02.01.2012 10:11, schrieb Rémi Denis-Courmont:
>>>    Hello,
>>>
>>> On Sunday 01 January 2012, Thomas Siegbert wrote:
>>>> Am 01.01.2012 21:11, schrieb Rémi Denis-Courmont:
>>>>>    Hello,
>>>>>
>>>>> I do not understand what this patch is supposed to do or it is wrong.
>>>>
>>>> Replace white spaces in an URL by "%20". Or did I do anything wrong?
>>>
>>> Why replace spaces? Then why replaces only spaces?
>>
>> I thought over it. Do you think, we should encode the entire URL?
> 
> There is no such thing as "encoding an entire URL". A URL is always encoded, 
> or it is not an URL.
> 
> You could however URL-encode bytes that are neither URL-safe nor URL-reserved. 
> That would turn a non-URL URL-lookalike string into a possibly valid URL.
> 

Ok, I see your point. I will fix it in the right way and send a new
patch. Thanks.

-Thomas



More information about the vlc-devel mailing list