[vlc-devel] [PATCH] Simplify MAKE detection and ./compile creation

Rafaël Carré funman at videolan.org
Fri Jan 6 03:43:44 CET 2012

Clarify what ./compile does
 configure.ac |   30 ++++++++++++++++++------------
 1 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/configure.ac b/configure.ac
index fec1f3c..74928f2 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4255,21 +4255,27 @@ dnl Generate makefiles
 dnl Do we have to use make or gmake ?
-USE_MAKE_OR_GMAKE=`case "${SYS}" in openbsd*) echo "gmake";; *) echo "make";; esac`
+if make --version 2>&1|grep -q GNU
+    # GNU make, all seems good
+    MAKE=make
+    # Known GNU make alias (on BSD)
+    MAKE=gmake
 dnl Shortcut to nice compile message
-rm -f compile
 if test -n $SHELL; then
-echo '#! '$SHELL >compile
-echo rm -f .error\$\$ >>compile
-echo ERROR=0 >>compile
-echo export PATH=$PATH LANG=C >>compile
-echo "($USE_MAKE_OR_GMAKE V=1 \$@ 2>&1 || touch .error\$\$)| \\" >>compile
-echo '`sed -ne "s/^top_srcdir *= *//p" < Makefile`/extras/buildsystem/make.pl' >>compile
-echo test -f .error\$\$ \&\& ERROR=1 >>compile
-echo rm -f .error\$\$ >>compile
-echo exit \$ERROR >>compile
+rm -f compile
+echo "#! $SHELL
+rm -f .error\$\$
+export PATH=\"$PATH\" LANG=C
+($MAKE V=1 \$@ 2>&1 || touch .error\$\$)| `sed -ne "s/^top_srcdir *= *//p" < Makefile`/extras/buildsystem/make.pl
+test -f .error\$\$ \&\& ERROR=1
+rm -f .error\$\$
+exit \$ERROR" >compile
 chmod a+x compile
 echo "
@@ -4285,4 +4291,4 @@ else
 echo "build vlc executable  : no"
 echo "
-To build vlc and its plugins, type \`./compile' or \`$USE_MAKE_OR_GMAKE'."
+To build vlc and its plugins, type \`$MAKE', or \`./compile' if you like nice colors."

More information about the vlc-devel mailing list