[vlc-devel] [PATCH] Change to npapi for giving access to media meta thru new input.meta(i) method.

[jm]

On 12/30/2011 02:21 AM, Jean-Baptiste Kempf wrote:
> On Wed, Dec 28, 2011 at 11:41:54PM +0100, JM Lambert wrote :
>> +
> Why?
>
>> +
>> +
> Idem?
>
>> -    "none",
>> +    "meta",
> That doesn't break anything? Instead of adding it?
No to me, the "none" is to be used when there is no method (that was the 
case prior to adding the meta() method)
> No, to
>
>> +        VlcPlugin* p_plugin = getPrivate<VlcPlugin>();
>> +        libvlc_media_player_t *p_md = p_plugin->getMD();
>> +	libvlc_media_t * p_media = libvlc_media_player_get_media(p_md);
> No tabs.
> If p_md was NULL, wouldn't this be bad?
Corrected
>
>> +        if( !p_md )
>> +            RETURN_ON_ERROR;
>>           switch( index )
>>           {
>> -            case ID_none:
>> -                return INVOKERESULT_NO_SUCH_METHOD;
>> +            case ID_input_meta:
>> +		if( argCount == 1)
> tabs
removed
>
>> +                {
>> +                    char *info;
> const?
corrected
>
>> +                    int i_metaID,  i;
> i is used?
removed i
>
> Btw, is this the best way to expose this API?
that's the simplest and does not require rebuild if fields are aded to 
meta. Which other way do you recommend ?
>
> Best regards,
>