[vlc-devel] [PATCH] Change goto to gotoitem for lua 5.2 compatibility.

Antoine Cellerier dionoea at videolan.org
Fri Jan 6 16:04:01 CET 2012


On Fri, Jan 06, 2012, Kelly Anderson wrote:
> >>>>-    { "goto"; { func = skip2(vlc.playlist.goto); help = "goto item at index" } };
> >>>>+    { "goto"; { func = skip2(vlc.playlist.gotoitem); help = "goto item at index" } };
> >>>>+    { "gotoitem"; { func = skip2(vlc.playlist.gotoitem); help = "goto item at index" } };
> >I think this one is not needed though?
> 
> Might not be needed...but I thought it might be useful for completeness.
> i.e. users that write scripts in lua will get used to using gotoitem
> and might want to use that in the cli.  Kinda nice from a
> consistency standpoint.

I'd keep one command only (some other commands already don't map
to a corresponding C function anyway). (and I'd keep "goto", if
you really want to also provide gotoitem I think that you can add
aliases={"gotoitem"} at the end of the declaration. At least it wouldn't
declare a duplicate command)

-- 
Antoine Cellerier
dionoea



More information about the vlc-devel mailing list