[vlc-devel] [PATCH] Fixed a crash caused by yadif deinterlacer on Windows XP

[Naohiro KORIYAMA]

2012/1/10 Rafaël Carré <funman at videolan.org>:
> Le 2012-01-09 21:04, Rafaël Carré a écrit :
>
>> Does a build with CFLAGS='-msse -mmmx' work?
>
> http://people.videolan.org/~funman/vlc-1.3.0-git-win32-debug.7z
>
> I'm getting an XP iso and will install it in a VM to test it

Unfortunately it stop with SIGEGV on WIndows XP (XP mode).

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 3656.0xe88]
0x6798699a in yadif_filter_line_sse2 ()
   from c:\utils\fun\vlc-1.3.0-git\plugins\video_filter\libdeinterlace_plugin.dl
l
(gdb) bt
#0  0x6798699a in yadif_filter_line_sse2 ()
   from c:\utils\fun\vlc-1.3.0-git\plugins\video_filter\libdeinterlace_plugin.dl
l
#1  0x679881d9 in RenderYadif ()
   from c:\utils\fun\vlc-1.3.0-git\plugins\video_filter\libdeinterlace_plugin.dl
l
#2  0x6798236b in Deinterlace ()
   from c:\utils\fun\vlc-1.3.0-git\plugins\video_filter\libdeinterlace_plugin.dl
l
#3  0x6a5d2340 in FilterChainVideoFilter ()
   from c:\utils\fun\vlc-1.3.0-git\libvlccore.dll
#4  0x6a5d23ef in filter_chain_VideoFilter ()
   from c:\utils\fun\vlc-1.3.0-git\libvlccore.dll
#5  0x6a597487 in ThreadDisplayPreparePicture ()
   from c:\utils\fun\vlc-1.3.0-git\libvlccore.dll
#6  0x6a597e5f in ThreadDisplayPicture ()
   from c:\utils\fun\vlc-1.3.0-git\libvlccore.dll
#7  0x6a598159 in ThreadManage ()
   from c:\utils\fun\vlc-1.3.0-git\libvlccore.dll
#8  0x6a5994bd in Thread () from c:\utils\fun\vlc-1.3.0-git\libvlccore.dll
#9  0x6a5d717c in vlc_entry at 4 ()
   from c:\utils\fun\vlc-1.3.0-git\libvlccore.dll
#10 0x77bea3b0 in msvcrt!_endthreadex () from C:\WINDOWS\system32\msvcrt.dll
#11 0x7c80b729 in KERNEL32!GetModuleFileNameA ()
   from C:\WINDOWS\system32\kernel32.dll
#12 0x00000000 in ?? ()
(gdb)

I don't run Windows XP  on real machine, but maybe same result.
I heard the crash from two user, one use bootcamp on Mac, one use on
real machine.

>
>> If it does, that maybe a good occasion to enable MMX and SSE
>> optimizations in VLC by default and wish "good bye, use VLC 1.1 if you
>> want" to these old CPUs.
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel



-- 
KORIYAMA, Naohiro
nkoriyama at gmail.com