[vlc-devel] [PATCH] Fixed a crash caused by yadif deinterlacer on Windows XP

[Rafaël Carré]

Le 2012-01-10 00:11, Naohiro KORIYAMA a écrit :
> 2012/1/10 Rafaël Carré <funman at videolan.org>:
>> Le 2012-01-09 23:31, Naohiro KORIYAMA a écrit :
>>
>>>>> I also found
>>>>> https://bugzilla.mozilla.org/show_bug.cgi?id=631252
>>>>> and after appending "-mstackrealign" to CFLAGS, it works on Windows XP.
>>>>>
>>>>> So, I want to revert the last patch(577b183d295adbea85e03502d73d04fd3f90ef90),
>>>>
>>>> Reverted
>>>
>>> Thank you.
>>>
>>>>> and want to append "-mstackrealign" on configure.ac.
>>>
>>> And can we add "-mstackrealign" to somewhere on configure.ac for Windows XP?
>>
>> http://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html
>>
>> force_align_arg_pointer will realign the stack only for functions where
>> it is used apparently so it looks more efficient.
> 
> I now think so too and appending "-mstackrealign" globally may cause
> bad (or good) affects to another modules.
> 
> I tested "force_align_arg_pointer" on win32 build, and it works on
> Windows XP, too.
> So, after I tested a patch on another platforms, I sent a patch, like this:
> + #if defined(__MINGW32__) && defined(WIN32) && !defined(WIN64)
> + __attribute__((__force_align_arg_pointer__))
> + #endif
> VLC_TARGET static void RENAME(yadif_filter_line)(uint8_t *dst,

Looks like a good workaround to me (and I'm hoping it really changed
something and won't fail at some random point in the future)

Perhaps we should mention why it's here though.