[vlc-devel] [PATCH 12/48] hls: Don't change playlist

[Jean-Paul Saman]

NACK this patch does something else then it descriptions says.

On Mon, Jan 9, 2012 at 4:16 PM, Hugo Beauzée-Luyssen <beauze.h at gmail.com> wrote:
> From: Luc Saillard <luc.saillard at sfr.com>
>
> ---
>  modules/stream_filter/httplive.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/modules/stream_filter/httplive.c b/modules/stream_filter/httplive.c
> index de65609..9788c7d 100644
> --- a/modules/stream_filter/httplive.c
> +++ b/modules/stream_filter/httplive.c
> @@ -1530,6 +1530,8 @@ static int hls_DownloadSegmentData(stream_t *s, hls_stream_t *hls, segment_t *se
>     /* Do not change bandwidth */
>     return VLC_SUCCESS;
>
> +    return VLC_SUCCESS;
> +

This is a non change.

>     /* check for division by zero */
>     double ms = (double)duration / 1000.0; /* ms */
>     if (ms <= 0.0)
> @@ -1951,7 +1953,7 @@ static int Open(vlc_object_t *p_this)
>
>     /* Choose first HLS stream to start with */
>     hls_ChooseDefaultStream(p_sys);
> -    int current = p_sys->playback.stream;
> +    int current = p_sys->playback.stream = p_sys->b_live ? 3 : 0;

This actually changes p_sys->playback_stream value. If you want to
influence what segment is choosen, then you should alter
ChooseSegments() to behave differently.

>     p_sys->playback.segment = p_sys->download.segment = ChooseSegment(s, current);
>
>     /* manage encryption key if needed */
> --
> 1.7.8.3
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel

Kind regards,

Jean-Paul Saman