[vlc-devel] [PATCH] AVI: add an automatic decision choice for AVI index

[Laurent Aimar]

On Wed, Jan 11, 2012 at 09:48:56AM +0100, Jean-Baptiste Kempf wrote:
> On Wed, Jan 11, 2012 at 09:43:19AM +0100, Rémi Denis-Courmont wrote :
> > On Wed, 11 Jan 2012 09:04:57 +0100, Jean-Baptiste Kempf <jb at videolan.org>
> > wrote:
> > > On Wed, Jan 11, 2012 at 10:04:27AM +0200, Juha Jeronen wrote :
> > >> On 01/10/2012 09:32 PM, Jean-Baptiste Kempf wrote:
> > >> > On Tue, Jan 10, 2012 at 08:26:31PM +0100, Laurent Aimar wrote :
> > >> >>> Any problem if it replaces the 'always fix' option?
> > >> >> Well, some AVI have broken index and it's nice (even if advanced)
> > >> >> to have a way to rebuild it.
> > >> > I would call that "Force fix", to be honest, to avoid the confusion.
> > >> 
> > >> Well, at least I'm already confused :)
> > >> 
> > >> What's the difference between "Always fix" and the suggested new
> > >> "Automatically fix"?
> > >> 
> > > 
> > > Always fix always rebuilds the AVI index.
> > > "Automatically fix", my proposal, is to rebuild the AVI index, every
> > > time it is necessary, but without asking. Because, those days,
> > > rebuilding the index is faster than asking the user to...
> > 
> > Isn't that a case for removing the "ask" choice?
> 
> That's my opinion for the long term, indeed.
> But so far, I don't know how well automatically behaves for important
> sized avi over http or avi-getting-downloaded-by-p2p-programs...

I think it might be better to simply not rebuild the index by default.

Basically what you loose is:
 - the media length (I need to check but I don't think it prevents time
seeking in the case of AVI files)
 - seek precision (this one can be annoying with non interleaved files,
but otherwise it's not bad)

but building the index can be quite long especially with non local files
(like when using fuse/samba).

-- 
fenrir