[vlc-devel] [PATCH] Small change to let other keyboard layouts have hotkeys

Militaru Cristian cristipiticul at gmail.com
Thu Jan 12 18:01:05 CET 2012

> My only point is that you cannot blindly pass unknown Qt symbols to VLC.

Why not? I mean, if the user wants to put a weird key as a hotkey, do you
think it's better returning 0 than letting the key as it is?

I have one question: is the VLC hotkey processing based also on a
QKeyEvent? If so, then the conversion of the Qt key to a VLC key would be
done twice, once when adding it, and also when pressing it.

My point is, the only difference the patch makes is intended to work only
on unknown keys. Those are not currently processed and I don't think it's
that blindly passed as you think. I don't think Qt wouldn't use the
standard for the keys they don't care for, such as those unknown keys in
this case, because that would require more coding, time and nerves. I think
this is the one of the best and simplest solutions and it's much better
than letting 0, at least.

I have only one improvement, but I guess you won't like it: using scan
codes it's quite easy to determine whether if the key pressed was a letter
(comparing to some values), something like the "if" I suggested in the
first patch ( a longer one :D ).

Thank you for your help, time and nerves.

I'm looking forward to your responses.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20120112/744047c0/attachment.html>

More information about the vlc-devel mailing list