[vlc-devel] [vlc-commits] Audio channel remapping filter

[Cheng Sun]

On 12/01/12 08:12, Rémi Denis-Courmont wrote:
> On Thu, 12 Jan 2012 01:59:11 +0100 (CET), git at videolan.org (Cheng Sun)
> wrote:
>> vlc | branch: master | Cheng Sun <chengsun9 at gmail.com> | Wed Dec 21
>> 16:37:11 2011 +0000| [10d3c50696d945ea8d29d57eca2e3cf25e02e08d] |
>> committer: Jean-Baptiste Kempf
>>
>> Audio channel remapping filter
> 
> My earlier comments were ignored here.
> 

Sorry? I don't see any earlier comments which I hadn't responded to.
There were some metadata issues which j-b pointed out, which I hadn't
gotten round to, but apart from that all others I (believe I) had dealt
with:

> This is useless since you already check that format are identical:
> 
> This is useless since you have a list of supported formats in GetRemapFun(). 
> However, you should move GetRemapFun() earlier in probing.
> 
> You are not supposed to change the rate, unless you're implementing a 
> resampler.
> 
> That is also useless.

Cheng