[vlc-devel] contents of vlc-devel Digest, Vol 56, Issue 80

[jean-michel Lambert]

On 13/01/2012 04:55, vlc-devel-request at videolan.org wrote:
> Date: Fri, 13 Jan 2012 10:51:30 +0700 From: Sergey Radionov 
> <rsatom at gmail.com> To: Mailing list for VLC media player developers 
> <vlc-devel at videolan.org> Subject: Re: [vlc-devel] [PATCH] NPAPI 
> change: introduce MediaDescription object for exposing media meta 
> information Message-ID: 
> <CADOtZwhgS5_NgKzjzj++KWauDTstZJsLShyVoNAEH6abj_ZeEQ at mail.gmail.com> 
> Content-Type: text/plain; charset=ISO-8859-1 2012/1/13 JM Lambert 
> <jeanmichel.lambert7 at gmail.com>:
>> >  ---
>> >  ?npapi/control/npolibvlc.cpp | ?140 +++++++++++++++++++++++++++++++++++++++++++
>> >  ?npapi/control/npolibvlc.h ? | ? 24 +++++++-
>> >  ?2 files changed, 163 insertions(+), 1 deletions(-)
>> >
>> >  diff --git a/npapi/control/npolibvlc.cpp b/npapi/control/npolibvlc.cpp
>> >  index a8a94f6..651a572 100644
>> >  --- a/npapi/control/npolibvlc.cpp
>> >  +++ b/npapi/control/npolibvlc.cpp
>> >  @@ -99,6 +99,7 @@ const NPUTF8 * const LibvlcRootNPObject::propertyNames[] =
>> >  ? ? "subtitle",
>> >  ? ? "video",
>> >  ? ? "VersionInfo",
>> >  + ? ?"MediaDescription"
>> >  ?};
>> >  ?COUNTNAMES(LibvlcRootNPObject,propertyCount,propertyNames);
>> >
>> >  @@ -110,6 +111,7 @@ enum LibvlcRootNPObjectPropertyIds
>> >  ? ? ID_root_subtitle,
>> >  ? ? ID_root_video,
>> >  ? ? ID_root_VersionInfo,
>> >  + ? ?ID_root_MediaDescription,
>> >  ?};
>> >
>> >  ?RuntimeNPObject::InvokeResult
>> >  @@ -143,6 +145,12 @@ LibvlcRootNPObject::getProperty(int index, NPVariant&result)
>> >  ? ? ? ? ? ? case ID_root_VersionInfo:
>> >  ? ? ? ? ? ? ? ? return invokeResultString(libvlc_get_version(),result);
>> >  ? ? ? ? ? ? default:
>> >  + ? ? ? ? ? ?case ID_root_MediaDescription:
>> >  + ? ? ? ? ? ?{
>> >  + ? ? ? ? ? ? ? ?InstantObj<LibvlcMediaDescriptionNPObject>( mediaDescriptionObj );
>> >  + ? ? ? ? ? ? ? ?OBJECT_TO_NPVARIANT(NPN_RetainObject(mediaDescriptionObj), result);
>> >  + ? ? ? ? ? ? ? ?return INVOKERESULT_NO_ERROR;
>> >  + ? ? ? ? ? ?}
> why did you place it after "default:"?
>
sure will resubmit complte patch with this copy&paste issue corrected (I 
aslo forgot about the release of the new object in the root destructor)