[vlc-devel] [PATCH 1/2] macosx: Lua extensions infrastructure

[Felix Paul Kühne]

On 12.01.2012, at 22:36, Brendon Justin wrote:

> Code for launching Lua extensions on Mac OS X.  Much of the code is from the
> macosx_dialog_provider.

Thanks for the patch, which looks very promising!

a few remarks:

- Why did you import the VLCLoginPanel and the VLCProgressPanel from the dialog provider? These dialogs are handled by the VLCCoreDialogProvider (see .../gui/macosx/coredialogs.*) within the ordinary Mac interface, so you shouldn't need them. To hide this from you, the macosx dialog provider defines these dialogs in code, while the mac interface mostly uses an xib file for that ;-)

- ExtensionsManager.m includes an incorrect copyright header (file name, date [jpeg didn't contribute in 2012, so his code must be older])

- EXTENSION_WIDGET_HTML needs to be re-implemented. we can do that after the merge though. it isn't trivial and less important.

well, that's all I got to grouch about this patch. Thanks a lot!


Best regards,

Felix