[vlc-devel] [PATCH] ActiveX: switch to vlc_player_options

[Sergey Radionov]

2012/1/14 Cheng Sun <cheng.sun at ymail.com>:
> On 14/01/12 14:26, Cheng Sun wrote:
>> On 14/01/12 11:57, Sergey Radionov wrote:
>>> ---
>>>  activex/plugin.cpp |    8 ++++----
>>>  activex/plugin.h   |   16 +++++++---------
>>>  2 files changed, 11 insertions(+), 13 deletions(-)
>>
>> Right now we need to consolidate all code to use vlc_player_options.
>> Currently the autoplay/toolbar/mute etc. flags (that you are trying to
>> supersede with vlc_player_options) are only set (and used) on startup,
>> i.e. when dynamically changing states (by user or by script) these flags
>> are not changed to the right values. We need to change everywhere we use
>> set_toolbar_visible/set_fullscreen/... to instead use the
>> vlc_player_options callback functionalities.
>>
>> (e.g. see vlcplugin_gtk.cpp: get_fullscreen() returns its own private
>> is_fullscreen flag instead of utilising the new vlc_player_options)
>>
>> Cheng
>
> Perhaps my explanation above was unclear. I mean that instead of
> implementing set_toolbar_visible the VlcPlugin* classes should now
> register a listener with vlc_player_options, and instead of calling
> set_toolbar_visible we should instead change these to set_show_toolbar.
> (If so, this should also be done with set_fullscreen)
Exactly! Now you are understanding my big plan :)

>
> Cheng
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel