[vlc-devel] [PATCH 2/2] add V4L2 video_output module

[Rafaël Carré]

Le 12-01-14 08:36, Francois Cartegnie a écrit :
> Le 14/01/2012 03:43, Rafaël Carré a écrit :
> 
>>> +/* ! from v4l2 access */
>>
>> does that mean that the function is defined 2 times?
> 
> We have a truncated fallback but want to keep track of the original order.
> 
> But yes, some code could be shared with v4l2 access/input.
> 
>>> +        vlc_fourcc_t i_fourcc;
>>> +        int i_foo;
>>> +        b_codec_supported = get_fourcc_by_v4l2pixelformat( &i_fourcc,
>>> +                                                           &i_foo,
>>> +                                                           &i_foo,
>>> +                                                           &i_foo,
>>> +                                                           codecs[i].pixelformat );
>>
>> you could initialize codecs[i].reserved[0] directly?
> 
> Not sure I get your remark.
> I use the driver extensions reserved space as storage to avoid declaring
> a new struct.

I meant no need for b_codec_supported variable since it's assigned to
codecs[i].reserved[0] in all case and only used here