[vlc-devel] Report on contrib tree clang issues

[Rafaël Carré]

Le 2012-01-16 21:19, Olivier Gambier a écrit :
> Hi list,
> 
> Following on the previous discussion on that topic:
> http://mailman.videolan.org/pipermail/vlc-devel/2011-November/083724.html
> 
> and using clang 3.
> 
> Most stuff is fine now, except:
> 
> 
> * Libgcrypt: still needs the mentioned patches (from homebrew)
> use CFLAGS="-std=gnu89 -fheinous-gnu-extensions"
> configure with --disable-asm
> Apply https://trac.macports.org/browser/trunk/dports/devel/libgcrypt/files/clang-asm.patch

Does it work on other compilers/platforns ?

> * Libcaca: still needs to be patched as well (this one from homebrew)
> 
> --- libcaca/caca/caca.h 2011-07-05 00:09:51.000000000 -0700
> +++ libcaca.new/caca/caca.h 2011-07-05 00:10:10.000000000 -0700
> @@ -645,7 +645,7 @@
>  #       define CACA_DEPRECATED
>  #   endif
>  
> -#   if defined __GNUC__ && __GNUC__ > 3
> +#   if !defined __APPLE__ && defined __GNUC__ && __GNUC__ > 3
>  #       define CACA_ALIAS(x) __attribute__ ((weak, alias(#x)))
>  #   else
>  #       define CACA_ALIAS(x)

Does clang define __GNUC__ ?

> * zvbi:
> 
> There is a patch from a Freebsd port for the nested function issue:
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/libzvbi/files/patch-src-packet.c?rev=1.1;content-type=text%2Fplain
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/libzvbi/files/patch-src-teletext.c?rev=1.1;content-type=text%2Fplain
> 
> and see: http://www.freshports.org/commit.php?category=devel&port=libzvbi&files=yes&message_id=201112150652.pBF6qgNm092931@repoman.freebsd.org
> 
> As for the #if #cpu problem, the freebsd port replaces them by defined in their Makefile, though that should be looked into…



> I gave up on live555 though… but everything else seems fine :)
> 
> 
> 
> 
> 
> In the hope these infos will help

It would be better if you provide patches against contrib/ that we can
apply directly