[vlc-devel] [vlc-commits] Implement libvlc_video_get_size(), close #3679

[Rémi Denis-Courmont]

Le lundi 16 janvier 2012 01:32:57 Rafaël Carré, vous avez écrit :
> > Can't you reflect a bit on the code you're writing?
> 
> I can

Then DO IT.

> > What if p_md is NULL?
> 
> I guess it's a crash?
> 
> > Sorry, but you cannot claim that it is hard to think
> > about a pointer (not) being NULL! And oh, libvlc_media_get_tracks_info,
> > first line, is an assert() about this exact problem.
> 
> Never made such a claim?

That's irrelevant. If you could easily think about it, then what's your excuse 
for not actually giving it a thought?

You keep committing lightly and that's really disrespectful for other 
developers, especially those that actually review commits.

-- 
Rémi Denis-Courmont
http://www.remlab.net/
http://fi.linkedin.com/in/remidenis