[vlc-devel] [PATCH] add V4L2 video_output module

[Francois Cartegnie]

Le 17/01/2012 20:47, Laurent Aimar a écrit :

>> +#define V4L2_PROFILE_LONGTEXT N_("Profile (chroma + size) for special apps using v4l2loopback")
>> +#define V4L2_CHROMA_TEXT N_("Chroma used")
>> +#define V4L2_CHROMA_LONGTEXT N_("Force use of a specific chroma for output. Default is I420.")
>  Can't this be auto detected ?

As I mainly target v4l2 loopback device, I need to be able to force the
mirrored format.

>> +    vd->pool    = Pool;
>> +    vd->prepare = NULL;
>> +    vd->control = Control;
>> +    vd->manage  = NULL;
>> +    vout_display_SendEventFullscreen(vd, false);
>  You MUST not change any properties of vd (except vd->sys) nor send any event
> before you are sure to return VLC_SUCCESS (as it is done by all other vout
> plugins).

Did not read about this.
Add it in header ? (vlc_vout_display.h #266)

>  I don't really see the need of the poollock if you don't provide direct
> memory rendering.
>  Shouldn't you do what you do in poollock in vd->prepare() instead ?

Probably. That would also save some lines.

Francois