[vlc-devel] Report on contrib tree clang issues

[Olivier Gambier]

Le 17 janv. 2012 à 22:14, Jean-Baptiste Kempf a écrit :

> On Tue, Jan 17, 2012 at 03:19:18AM +0100, Olivier Gambier wrote :
>> -#   if defined __GNUC__ && __GNUC__ > 3
>> +#   if !defined __APPLE__ && defined __GNUC__ && __GNUC__ > 3
>> #       define CACA_ALIAS(x) __attribute__ ((weak, alias(#x)))
>> #   else
>> #       define CACA_ALIAS(x)
> 
> Isn't that changing the behaviour of gcc-4.2 on Apple?

I think it does.
If we are to avoid changing behavior at all cost, then the latest suggestion would probably be better:

if !(defined __APPLE__ && defined __llvm__) && defined __GNUC__ && __GNUC__ > 3

That would just exclude llvm-gcc (which is spewing warnings about not being able to use weak alias) and clang (which fails on it), but only on OSX (as this is reported / supposed to affect only OSX).


What do you think?


Best,

- Olivier