[vlc-devel] Réf : Re: [PATCH] v4l2: check if kernel headers are recent enough

[Rafaël Carré]

Le 2012-01-19 13:31, Rémi Denis-Courmont a écrit :
> Le jeudi 19 janvier 2012 20:19:48 Rafaël Carré, vous avez écrit :
>> Not supporting it doesn't mean try to build anyway.
>>
>> We check if the C compiler is present but obviously we don't support the
>> absence of it
> 
> Actually... configure does not fail if the C compiler is too old (try gcc-3.2 
> or egcs for a laugh) even though the compilation will ultimately fail in 
> obscure ways. That is pretty much the same situation.

No since we can detect it.

Pushed (needed for android NDK at least).

Le 2012-01-19 02:11, Rémi Denis-Courmont a écrit :

> And
> builders do ignore warnings. Next thing, they will come and complain that
> v4l2:// stopped working silently. I'd rather have the build system explode
> in their face really.

It can be changed to an error if we add an option to disable v4l2.
Distros usually have recent kernel, so old distros with old kernels are
likely to have more problems than just v4l2 and debian has a list of
installed files so it would not go unnoticed.

> Furthermore I am not a fan of patching configure.ac as it is slow as hell.

I agree that it is slow but this commit doesn't make it particularly slower.