[vlc-devel] [PATCH 07/12] bluray: Nasty hack to avoid crashing when changing title.

[Jean-Baptiste Kempf]

On Sun, Jan 22, 2012 at 12:31:02AM +0100, Hugo Beauzée-Luyssen wrote :
> +static void blurayResetParser( demux_t *p_demux )
> +{
> +    demux_sys_t *p_sys = p_demux->p_sys;
> +    if ( p_sys->p_parser )
> +        stream_Delete( p_sys->p_parser );
> +    p_sys->p_parser = stream_DemuxNew(p_demux, "ts", p_demux->out);
> +    if (!p_sys->p_parser) {
> +        msg_Err(p_demux, "Failed to create TS demuxer");
> +    }
> +}

OK, but the style.

>      case    BD_EVENT_TITLE:
> -        if ( e->param < p_sys->i_title )
> -            blurayUpdateTitle( p_demux, e->param );
> +        blurayUpdateTitle( p_demux, e->param );

Re-doing what you undid before?

> +    case BD_EVENT_END_OF_TITLE:

Unrelated, IMVHO.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device