[vlc-devel] [PATCH 08/12] bluray: Adding support for overlay.

Jean-Baptiste Kempf jb at videolan.org
Mon Jan 23 01:32:50 CET 2012


On Sun, Jan 22, 2012 at 12:31:03AM +0100, Hugo Beauzée-Luyssen wrote :
> +#include <vlc_picture.h>
> +#include <vlc_vout.h>

Why? Please explain why.

> +//libbluray's overlay.h defines 2 types of overlay.
Inconsistant comment style.

> -    p_sys->p_parser = NULL;
> +    memset( p_sys, 0, sizeof( *p_sys ) );

use calloc.

Best regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list