[vlc-devel] [PATCH] contrib: disable thumb for packages that use ARM-only asm

[Rafaël Carré]

Le 2012-01-24 02:07, Rémi Denis-Courmont a écrit :
> On Tue, 24 Jan 2012 02:06:07 -0500, Rafaël Carré <funman at videolan.org>
> wrote:
>> Le 2012-01-24 02:02, Rémi Denis-Courmont a écrit :
>>> This will not work if AAPCS is not in use (and if interworking is not
>>> otherwise forced system-wide).
>>
>> I assume people using thumb knows what to do.
> 
> I don't. Precisely if you optimize code for size, you might not want to
> support interworking.

Currently I can build contribs with -mthumb (obviously skipping faad,
mad, speex and tremor), and vlc with -marm and linking will probably not
complain but VLC will still crash at runtime.

This patch doesn't try to solve that.

-mthumb is not enabled in contrib so if someone modifies contrib to add
it and forgets interworking i would say it is his problem.

I don't understand what is the link with AAPCS?
Thumb works with old ABIs too.


About code size, the unused veneers can be removed by linker optimizations.


And (in my case) VLC is as expected smaller when built with thumb.


What is the drawback if i push this?