[vlc-devel] [PATCH] Seek only if necessary and a few small changes

Rémi Denis-Courmont remi at remlab.net
Tue Jan 24 21:02:01 CET 2012

Le mardi 24 janvier 2012 21:22:13 Tobias Güntner, vous avez écrit :
> Hello!
> Am 21.01.2012 03:40, schrieb Rafaël Carré:
> > For the unneeded headers I don't agree with at least video_output.c
> > This file uses free() and man 3 free says it's declared in stdlib.h
> > 
> > If another header includes stdlib.h then the build will fail when that
> > other header is changed.
> But vlc_common.h already includes it (and several other "required system
> headers"). Isn't that the point of vlc_common.h?

That is a historical tolerance. Including <stdlib.h> or <stdio.h> explicitly 
is not wrong. In my opinion, only <stdint.h>, <stdbool.h> and <stddef.h> 
headers really should be included implicitly.

Rémi Denis-Courmont

More information about the vlc-devel mailing list