[vlc-devel] [PATCH] Enhance cmake based contribs cross-compilation

[Rémi Denis-Courmont]

On Wed, 25 Jan 2012 02:02:50 +0100, Olivier Gambier <olivier at webitup.fr>
wrote:
> Hi,
> 
> If I understand correctly, we are able to cross-compile cmake based
> contribs only for windows and osx targets - because we don't specify a
> CMAKE_SYSTEM_NAME for anything else (in main.mak).
> Actually, this fact does prevent from building correctly at least taglib
> and musepack from OSX to Linux (compilation partly works, but it fails
> linking due to cmake thinking this is a native build and trying to use
> system tools).
> 
> It seems the needed fix is just to specify explicitly  a
CMAKE_SYSTEM_NAME
> in the toolchain file (http://www.vtk.org/Wiki/CMake_Cross_Compiling)
> 
> If that sounds ok, I would like to propose the attached patch.
> It should alter the behavior ONLY when cross-compiling to a linux
target.
> But I guess that might alter things when targeting android, right? In
that
> case, and if that wouldn't be desirable, I guess we could amend the
patch
> to exclude android and keep the current state of affairs for that
platform
> (whatever it is).
> 
> What do you think?

I do not see why you need to check for cross-compilation, but then again I
have not tested with nor without the check.

-- 
Rémi Denis-Courmont
http://www.remlab.net/