[vlc-devel] [PATCH 2/4] Mimic a behavior of GNU libiconv on OS/2

[KO Myung-Hun]

Rémi Denis-Courmont wrote:
> 	Hello,
> 
> Le mardi 10 janvier 2012 14:07:03 KO Myung-Hun, vous avez écrit :
>> DBCS countries assign their currency symbol to '\', ASCII 92. This causes
>> an unexpected behavior when converting a directory separator on OS/2.
> 
> WTF? You mean that iconv() on OS/2 converts the ASCII backslash to the South 
> Korean Won (KRW) symbol? Which 'tocode's are concerned?
> 

Yes. If CVTTYPE_PATH is not specified.

That is, if 'tocode' is Unicode(UTF-8, UCS-2) and 'fromcode' is Korean
codepage(EUC-KR, CP949), then '\'[5c] will be converted to KRW[20a9].

>> In case of GNU libiconv, it does not treat '\', ASCII 92, as a currency
>> symbol at all. So let's mimic GNU libiconv.
> 
> Maybe I see where you are going. But will that not corrupt the KRW symbol when 
> it is actually found in subtitles?
> 

I think, this is an inevitable problem. And this is not a specific to
OS/2 if converting a NLS string to an Unicode string.

However, if the subtitles are in Unicode, there will be no problem at all.

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 2.0.14
Under OS/2 Warp 4 for Korean with FixPak #15
On Intel Core2Duo T5500 1.66GHz with 2GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr