[vlc-devel] [PATCH 2/3] dash added byte range requests

Hugo Beauzée-Luyssen beauze.h at gmail.com
Sun Jan 29 01:56:33 CET 2012


2012/1/28 Christopher Müller <christopher.mueller at itec.uni-klu.ac.at>:
>
>
>

Hello,

If I'm not mistaking, this patch makes HttpConnection use net_*
instead of the old stream_*
Maybe this should be split in another patch. Also, some attributes
seems to be unused afterward (HttpConnection::urlStream) you should
probably remove them.
When you delete this->peekBuffer, you must use delete[] as it was
allocated with new[]
The class destructor should probably ensure the connection is closed,
if closeSocket wasn't called, it feels more natural.

Regards,

-- 
Hugo Beauzée-Luyssen



More information about the vlc-devel mailing list