[vlc-devel] [PATCH] macosx: Attempt to localize the advanced prefs dialog

[Felix Paul Kühne]

On 29.01.2012, at 15:21, David Fuhrmann wrote:

> 
> Am 29.01.2012 um 14:54 schrieb Felix Paul Kühne:
> 
>> Hi there,
>> 
>> On 29.01.2012, at 12:53, David Fuhrmann wrote:
>> 
>>> Hello again,
>>> 
>>> I noticed that the advanced prefs dialog never translated the strings shown on the right side (even not in VLC 1.1.x). That is because of the fact that 'localizedString:' is used which does not translate anything, but only converts a c string to an NSString.
>> 
>> Thanks for making me aware of that. I chose a different approach to this problem in [d285961c0b2422c8c5e7af0109263064ec8443d2]. I'll rework that code aspect for 2.0-next to have something nicer. Especially VLCMain isn't the place where string conversations should take place. This legacy code dating back to VLC 0.3.x in 2002..
> 
> Yeah, I also played around with this approach. But this leads to some problems, especially as sometimes p_item->psz_longtext (tooltip text) seems to be NULL. That leads to crashes when you select some parts in prefs as _() cannot handle NULL strings obviously.
> 
> Here, some extra ifs seems to be needed to avoid that.

Indeed, I'll look into that later on :-)


Best,

Felix