[vlc-devel] [PATCH] rand: Also use /dev/urandom on OpenBSD as well (for 2.0)

Brad brad at comstyle.com
Mon Jan 30 07:50:17 CET 2012

On older OpenBSD releases you especially should not have been
using /dev/random, nowdays due to changes all the device nodes
are actually all the same so either way this code can be simplified
to not special case OpenBSD in vlc_rand_init().

This is back porting 3fc4af487dc23113a3c9602e1022f464f3992601 to 2.0.

diff --git a/src/misc/rand.c b/src/misc/rand.c
index ec78ebe..875c733 100644
--- a/src/misc/rand.c
+++ b/src/misc/rand.c
@@ -50,15 +50,10 @@ static uint8_t okey[BLOCK_SIZE], ikey[BLOCK_SIZE];
 static void vlc_rand_init (void)
-#if defined (__OpenBSD__) || defined (__OpenBSD_kernel__)
-    static const char randfile[] = "/dev/random";
-    static const char randfile[] = "/dev/urandom";
     uint8_t key[BLOCK_SIZE];
     /* Get non-predictible value as key for HMAC */
-    int fd = vlc_open (randfile, O_RDONLY);
+    int fd = vlc_open ("/dev/urandom", O_RDONLY);
     if (fd == -1)
         return; /* Uho! */

This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

More information about the vlc-devel mailing list